bamaer commented on PR #9272: URL: https://github.com/apache/hop/pull/9272#issuecomment-6640289104
@mhamedbenjmaa thanks, nice addition. Code reviewed; built `core`, `engine`, `ui` and `rap` (checkstyle and spotless clean) and ran `HopPathTest` plus the existing painter/`SvgGc` tests, all green. Not run in Hop GUI or Hop Web. **Blocker** - There's no issue for this change yet. Please open a feature request describing the new *Hop line shape* option, then add `fixes #<issue>` to the PR title and description. That way the change is recorded in an issue as well as in the PR. **Should fix** - The curved hit test in `pointOnLine` (`HopGuiPipelineGraph`, `HopGuiWorkflowGraph`) has no test. Please add a SWTBot test in `rcp`, along the lines of `HopGuiPipelineGraphHopEnablingTest`: with *Curved* selected, clicking a point on the curve that is off the straight center-to-center line should select the hop. Otherwise this looks good. With *Straight* selected, the arrow, hop icons and hop selection stay where they were. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
