bamaer commented on PR #9290: URL: https://github.com/apache/hop/pull/9290#issuecomment-6677859222
Thanks @hansva, nice consolidation. I read through the change and built `core` from the PR head. `ValueMetaFactoryParseMetaTest`, `ValueMetaBaseTest`, `ValueMetaFactoryTest` and `RowMetaTest` pass locally. The plugin changes I only read; CI is green. No blockers from my side. The length reset can't affect parsing (String metas parse with the default parse masks). Fields without an explicit currency keep the default symbol, so only `ยค` masks with a set currency change, as the issue describes. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
