bamaer commented on PR #9295: URL: https://github.com/apache/hop/pull/9295#issuecomment-6677950778
Thanks @hansva, LGTM. Built the filterrows module from this branch and ran `FilterRowsTest`: 12/12 pass. With the old `FilterRows.java` restored, the new test fails on the `isSortedDescending()` assertion, so it covers the fix. One note for anyone trying the repro in #9294: with a plain `putRow` (Sort rows), each hop gets its own clone of the row metadata (`BaseTransform.putRowToRowSet`), so a second hop out of Sort rows isn't affected. The metadata is only shared when the upstream transform uses `putRowTo` (Switch/Case, Filter rows with true/false targets, Java filter, the executors) or sends over an error hop. The fix covers those cases as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
