bamaer commented on PR #9304: URL: https://github.com/apache/hop/pull/9304#issuecomment-6678366397
Thanks @hansva, LGTM. Built the branch and ran `ScriptValuesAddedFunctionsTest` (3/3 pass). With the old loop put back, `padWithAnEmptyFillerReturnsTheValue` times out after 5 s, so the test covers the hang. Non-empty fillers pad exactly as before, and returning the value unchanged for an empty filler matches `Const.lpad`/`rpad` in core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
