bamaer commented on PR #9319: URL: https://github.com/apache/hop/pull/9319#issuecomment-6679407004
Thanks @leehaut, both points are resolved: delete and move leave the destination alone, and the Fail case counts once. Tests pass on 6c19d28. Great work on this one: seven separate issues fixed in one go, solid conflict tests, and a quick, careful turnaround on the review. One thing before merge: the move calls changed from `HopVfs.moveFile(sourceFileName, destinationFile)` to `sourceFileName.moveTo(destinationFile)` (three places in each action), which looks like an accidental undo of #7918 (#5936). `moveTo` fails when the move-to folder is on another filesystem. With the source on tmpfs and the move-to folder on disk, the action ends false with "Could not rename". With `HopVfs.moveFile` back it passes. Could you restore those six calls? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
