leehaut opened a new pull request, #9275: URL: https://github.com/apache/hop/pull/9275
Fix https://github.com/apache/hop/issues/9198 Since Hop 2.18, Send Nagios passive check stops the workflow with `NoClassDefFoundError: org/apache/commons/lang/Validate`. The action uses jsendnsca 2.1, which calls `org.apache.commons.lang.Validate`. That dependency was excluded and previously came from `lib/core`. Removing Commons Lang 2 (#6878) left the class unavailable to the plugin classloader, and the `Error` is not caught by `execute()`, so no hop from the action is followed. Upgrade the plugin to `com.github.jsendnsca:jsendnsca:3.0.0`. The Java packages and builder API are unchanged, and 3.0.0 uses `org.apache.commons.lang3.Validate`. Transitive dependencies stay excluded: `commons-lang3` and BouncyCastle are already in `lib/core`, and the plugin lib only ships `jsendnsca`. The 2.1 artifact was resolved from Clojars; 3.0.0 is on Maven Central, so that repository is removed. The action page no longer documents the missing class. ## Test plan - [x] Run a workflow whose Send Nagios passive check action has a host and a message set, against `127.0.0.1:5667` with no NSCA server. - [x] Before this change the log shows `NoClassDefFoundError: org/apache/commons/lang/Validate` and neither the success nor the failure hop runs. - [x] After rebuilding the plugin, the same workflow logs `ConnectException: Connection refused`, the action result is `false`, and the failure hop runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
