bamaer commented on PR #9347: URL: https://github.com/apache/hop/pull/9347#issuecomment-6694037148
Thanks @hansva. Built the cube plugin from this branch and ran its tests (23/23 pass). A quick 1M-row check gives about 2.2x faster writes and 5x faster reads; the decompressed content and the file size are the same as before, so existing cube files are unaffected. The buffer is flushed before the GZIP stream finishes in `dispose()`, also on the error path. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
