nadment opened a new issue, #9376:
URL: https://github.com/apache/hop/issues/9376

   ### What needs to happen?
   
   Remove the positive check results, `ICheckResult.TYPE_RESULT_OK`, produced 
by the `check()` methods of the transforms and the actions. They are no longer 
used and are not visible.
   
   The results of the verification of a pipeline or a workflow in Hop GUI skip 
them:
   
   - 
[HopGuiPipelineCheckDelegate.java#L296](https://github.com/apache/hop/blob/7b976ba9d83b35e790f2b0f1b294afb98dfe6a52/ui/src/main/java/org/apache/hop/ui/hopgui/file/pipeline/delegates/HopGuiPipelineCheckDelegate.java#L296):
 `if (cr.getType() == ICheckResult.TYPE_RESULT_OK) continue;`
   - 
[HopGuiWorkflowCheckDelegate.java#L270](https://github.com/apache/hop/blob/7b976ba9d83b35e790f2b0f1b294afb98dfe6a52/ui/src/main/java/org/apache/hop/ui/hopgui/file/workflow/delegates/HopGuiWorkflowCheckDelegate.java#L270):
 same
   
   `CheckResultDialog`, which can still show the successful results, is only 
used by the unit testing plugin to check the location of a CSV file, not to 
verify the transforms and the actions.
   
   Yet these results are still built, with a message to translate for each of 
them, which makes the `check()` methods longer and adds keys to every 
translation file. For example, "Number of row clones is specified." or 
"Transform is receiving info from other transforms.".
   
   Where they are produced:
   
   - The transforms: about 175 files under `plugins/transforms` use 
`TYPE_RESULT_OK`, plus `DummyMeta` and `InjectorMeta` in the engine.
   - The actions: mostly through the validators, 
[`ActionValidatorUtils.addOkRemark`](https://github.com/apache/hop/blob/7b976ba9d83b35e790f2b0f1b294afb98dfe6a52/engine/src/main/java/org/apache/hop/workflow/action/validator/ActionValidatorUtils.java#L192)
 called by `AndValidator` for each validated property, and directly in 
`ActionAbort`.
   - 
[`PipelineMeta`](https://github.com/apache/hop/blob/7b976ba9d83b35e790f2b0f1b294afb98dfe6a52/engine/src/main/java/org/apache/hop/pipeline/PipelineMeta.java#L3033)
 also adds one.
   
   Proposal:
   
   - Report only the errors and the warnings in `check()`: a valid setting 
gives no remark.
   - Remove the messages that are no longer used from the translation files.
   - Keep the constant `ICheckResult.TYPE_RESULT_OK`, still used by 
`CheckResultDialog`.
   - Update the unit tests that count or expect the positive remarks.
   
   The work can be split by plugin or by group of plugins.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Actions, Component: Transforms
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to