mattcasters commented on PR #8649: URL: https://github.com/apache/hop/pull/8649#issuecomment-6606977207
Thanks @hansva, that was a very useful review. I rebased onto main and reworked the gates along the lines you suggested. - **Run identity:** the spool is keyed by the source execution ID, and a successful workflow deletes that execution's folder. Every engine records gates now; only the Replay engine skips. - **Invalidation:** a sealed gate is reused only when the SHA-256 of the action XML, the workflow parameters and the variables referenced in that XML still match. Variables the action changed are stored and restored. - **Start action / paths:** skipping is decided per path. Once an action on a path has to run, the rest of that path runs, sealed or not, and parallel branches keep their own decision. - **Transform gates:** dropped. Nothing read the spool back, so that becomes a follow-up. - **Core serializer changes:** taken out of this PR. I split them out so they can get their own issue and PR. - **Test:** a new integration test fails mid-way, replays, and checks which actions ran or were skipped, including a parallel branch and the start action. The docs now describe only what the code does. The inline items (run configuration `clone()`, the dialog recipe, i18n, the Execution perspective button) are addressed too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
