bamaer commented on PR #9106: URL: https://github.com/apache/hop/pull/9106#issuecomment-6628345415
@hansva the blocker from the first review is fixed: transforms that share a connection in a transactional pipeline now go through `SharedConnectionLock`, so their savepoints no longer release each other's. The three points in the review from @mattcasters are also fixed: - No transform rolls back to a released savepoint any more. Only the row's SQL runs inside `runInSavepoint()`; `putRow`, `putError` and the commit run after it. - Update and Delete turn batch mode off when row savepoints are in use, and log why. - Failsafe is bound in the five transform poms, so the `*PostgresIT` tests run in `mvn verify`. Follow-up, not blocking: Synchronize after merge does not turn batch mode off when it uses row savepoints. On PostgreSQL, `supportsErrorHandlingOnBatchUpdates()` returns false, so with an error hop and "Use batch updates" `data.batchMode` stays true while every row runs as a single statement behind a savepoint. The batch bookkeeping (line counts, rows buffered for output, `executeBatch`) then works on an empty batch. The fix is the same guard Update and Delete use. A separate issue will track it. Approving. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
