mattcasters opened a new pull request, #9238: URL: https://github.com/apache/hop/pull/9238
The column-header menu on a TableView (Add filter, Hide column) picked its column by walking column widths and subtracting the horizontal scrollbar. Once the grid is scrolled, that addresses a column to the right of the pointer. Show rows uses this menu for Add filter. A header click is in the same coordinate space as `TableItem.getBounds`. On GTK that space is the bin window: scrolling leaves the cell bounds where they are and moves the client-area origin, so subtracting the scrollbar shifts the hit a second time. On Windows the scrollbar position is device pixels while the click and the cell bounds are in points. The menu now uses the painted cell bounds. fixes #9232 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
