bamaer commented on PR #9261:
URL: https://github.com/apache/hop/pull/9261#issuecomment-6636369372

   Thanks @leehaut, built this and ran `MailValidationTest` (5/5), spotless and 
checkstyle. Called `getMX()` against live DNS: `neverssl.com` now gives 
`[34.223.124.45]` (was `Index 1 out of bounds`), `gmail.com` still gives its MX 
hosts, and `example.com` (null MX `0 .`) gives an empty list, so it fails as 
"no machines" instead of trying an empty host.
   
   **Should fix**
   
   - The Mail validator page still describes the old behaviour (from #9195), so 
it is wrong once this is merged. In 
`docs/hop-user-manual/modules/ROOT/pages/workflow/actions/mailvalidator.adoc`:
     - line 58: "has no MX record" → "has no MX or A record"
     - line 65: replace the NOTE with: "*SMTP check* connects to port 25 of the 
mail servers of the domain (its MX records, or its A record when it has no MX 
record), or of *Default SMTP server* when it is set, and asks whether it 
accepts *Email sender* and the address."
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to