leehaut opened a new pull request, #9281: URL: https://github.com/apache/hop/pull/9281
Fix https://github.com/apache/hop/issues/9199 Fixes three workflow action result bugs found while documenting these actions. addresses #9199 - **Send SNMP trap:** loading a workflow turned a saved `user` target type back into `community`, so an SNMP V3 trap was sent as an SNMP V1 community trap. `getTargetTypeCode()` now accepts both the stored code and the localized description. - **Delete execution information:** success and failure hops were never followed because the action did not override `isEvaluation()`. It now returns true, so those hops follow the action result. An unconditional hop is unchanged. - **Set password encoder:** an unknown encoder plugin ID was reported as success and the process fell back to the Hop encoder. The action now checks the plugin registry first and fails without changing the active encoder or `HOP_PASSWORD_ENCODER_PLUGIN`. The user manual pages for these three actions are updated to match the fixed behavior. ## Test plan - [x] Open a workflow whose Send SNMP trap action is saved with `<targettype>user</targettype>`. The dialog shows User (SNMP V3), and User, Passphrase, and Engine ID stay enabled. Cancel so the file is not rewritten. - [x] Run Delete execution information against a missing location. The action result is false, the failure hop runs, and the success hop does not. An unconditional hop still runs. - [x] Run Set password encoder with plugin ID `Nope`. The action result is false, the failure hop runs, and the log does not say the encoder was initialized with `Nope`. - [x] `mvn -pl plugins/actions/snmptrap,plugins/actions/deleteexecutioninfo,plugins/actions/setpasswordencoder test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
