Adalennis opened a new pull request, #9432:
URL: https://github.com/apache/hop/pull/9432

   Fixes #9396
   
   Two fixes to the developer manual page `plugin-types/diagram-exporters.adoc`:
   
   - The `hop export` section named the wrapper scripts `hop-export` / 
`hop-export.bat`. The assembly ships `hop-export.sh` and `hop-export.bat` 
(`assemblies/static/src/main/resources`).
   - The Format paragraph called `DiagramExportFormat` an enum, and its 
example, `parse("PLANTUML")`, used a format that already has a constant. 
`DiagramExportFormat` is a class with constants for SVG, MERMAID, PDF, PLANTUML 
and DRAWIO. The paragraph now explains:
     - An unlisted id such as `format = "BPMN"` works, because 
`BaseDiagramExporter` passes the annotation's `format` to 
`DiagramExportFormat.parse(...)`, which creates the format from the id.
     - The file extension still comes from `fileExtension` in the annotation.
     - `DiagramExportFormat.of(...)` can be assigned to `format` in the 
exporter's constructor to set the format's name and MIME type.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us 
incorporate your contribution quickly and easily:
   - [x] Run `mvn clean install apache-rat:check` to make sure basic checks 
pass. A more thorough check will be performed on your pull request 
automatically.
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i`.
   - [x] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable.
   
   To make clear that you license your contribution under the [Apache License 
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to