leehaut opened a new pull request, #9463: URL: https://github.com/apache/hop/pull/9463
Fix https://github.com/apache/hop/issues/9443 ## Summary When the **Run pipeline unit tests** action names a unit test that does not exist, the error logged the `RunPipelineTestsField` object instead of the test name, and the closing quote was missing: ```text Unable to load unit test for 'org.apache.hop.testing.actions.runtests.RunPipelineTestsField@1ab9c735 ``` `RunPipelineTests` concatenated the field object in `execute()` and `loadReferencedObject()`. `RunPipelineTestsField` has no `toString()`, so the log showed the class name and identity hash. The same action also left the closing quote off three other messages: data-set validation, test-result evaluation, and an exception while executing a unit test. The messages now use `getTestName()` (or the loaded test name) and close the quote. A missing test still fails the action. The log is now: ```text Unable to load unit test for 'no-such-test' ``` ## Test plan - [x] `mvn -pl plugins/misc/testing -am "-Dtest=RunPipelineTestsTest" "-Dsurefire.failIfNoSpecifiedTests=false" test` — 4 tests, 0 failures - [x] In Hop GUI, run a workflow whose **Run pipeline unit tests** action names `no-such-test`. The log shows `Unable to load unit test for 'no-such-test'` and the action result is `false` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
