leehaut opened a new pull request, #9489: URL: https://github.com/apache/hop/pull/9489
Fix https://github.com/apache/hop/issues/9444 Exported SVG diagrams are sized from the coordinates stored in the file, starting at (0,0), instead of from what is painted. `PipelineMeta.getMaximum()` and `WorkflowMeta.getMaximum()` take the largest transform or action location, or a note location plus its stored width and height, and add 100. `PipelineSvgPainter` adds another 100. The canvas is always filled with `rgb(235,235,235)`, so that unused space shows up as a grey border. A pipeline placed away from the origin keeps a wide empty band on the left and the top. A note is painted at the larger of its stored size and the size its text needs, but the canvas only accounts for the stored size, so a workflow note can be cut off. `hop export` and Export to SVG in Hop GUI both go through these painters. The export painters now measure the painted bounds: the icon, the label under it, the description badge when one is drawn, and the note size `drawNote` actually uses. The drawing is shifted so the top-left of that box sits on a 16px margin, and the SVG is sized to the box plus the same margin on every side. `getMaximum()` is unchanged, so the editor canvas is not affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
