bamaer commented on code in PR #9529:
URL: https://github.com/apache/hop/pull/9529#discussion_r4598035932
##########
plugins/transforms/sortedmerge/src/main/java/org/apache/hop/pipeline/transforms/sortedmerge/SortedMerge.java:
##########
@@ -160,10 +164,12 @@ private void getRowSortedFirstCall() throws
HopTransformException {
}
}
+ // Compare with the metadata that carries the merge settings: the
metadata of the rows only
+ // says how they are sorted when the transform before this one says so
data.comparator =
(o1, o2) -> {
try {
- return o1.getRowMeta().compare(o1.getRowData(), o2.getRowData(),
data.fieldIndices);
+ return data.rowMeta.compare(o1.getRowData(), o2.getRowData(),
data.fieldIndices);
Review Comment:
Fair point @hansva: main only got that case right because it ignored the
setting, and the error says exactly what to change. With Get fields picking N,
the Verify warning and a line in the release notes, that works for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]