bamaer commented on code in PR #9538:
URL: https://github.com/apache/hop/pull/9538#discussion_r4596956668


##########
core/src/main/java/org/apache/hop/core/row/value/ValueMetaBase.java:
##########
@@ -292,7 +292,17 @@ protected ValueMetaBase(String name) {
     this(name, IValueMeta.TYPE_NONE, -1, -1);
   }
 
-  protected ValueMetaBase(String name, int type) {
+  /**
+   * Creates value metadata for components compiled against the legacy public 
constructor.
+   *
+   * @param name the field name
+   * @param type the value type
+   * @deprecated Retained for binary compatibility. Use {@link
+   *     ValueMetaFactory#createValueMeta(String, int)} for type-specific 
value metadata in new
+   *     code.
+   */
+  @Deprecated(since = "2.21")
+  public ValueMetaBase(String name, int type) {

Review Comment:
   @mattcasters this reopens one of the constructors #7387 made protected, as a 
deprecated bridge for already-compiled plugins. OK with you?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to