bamaer commented on code in PR #9565:
URL: https://github.com/apache/hop/pull/9565#discussion_r4619361809
##########
plugins/misc/testing/src/main/java/org/apache/hop/testing/xp/WriteToDataSetExtensionPoint.java:
##########
@@ -63,6 +64,10 @@ public void callExtensionPoint(
if (!writeToDataSet) {
return;
}
+ // The data set rows come from row listeners on the transforms of the
local engine
+ if (!(pipeline instanceof LocalPipelineEngine)) {
+ return;
+ }
Review Comment:
This also drops the single-threaded engine, which extends `Pipeline` but not
`LocalPipelineEngine` and fires `PipelineStartThreads`. "Write rows to data
set" in Hop GUI runs with whatever run configuration is selected, so on a
single-threaded run config this now silently writes nothing (it attached the
row listener on main), and the static maps are no longer cleaned up.
The listener only needs `findComponent()` / `addRowListener()`, so
`instanceof Pipeline` (as in the Reflection listeners) would keep the
single-threaded engine working and still skip the others. Checked with a mocked
`SingleThreadedPipelineEngine`: listener attached on main, not on this PR,
attached again with `instanceof Pipeline`; your 4 tests still pass with that
change.
I'd see it as a blocker since it silently changes something that works
today, but it's a niche path, so happy to hear if you think otherwise (e.g. if
writing data sets on the single-threaded engine was never meant to be
supported).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]