bamaer commented on PR #9571:
URL: https://github.com/apache/hop/pull/9571#issuecomment-6988916279

   Thanks @nadment. I built the PR and ran `UIGitTest` (80/80 pass). To back up 
@hansva's first point, I pushed to a local server that answers 403 to valid 
credentials, like an account without write access:
   
   - main: the push fails with `git-receive-pack not permitted on '…'`
   - this PR: no error. The dialog reopens for every correct password, and 
Cancel returns without a message.
   
   That change for read-only accounts is the part I'd see as blocking.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to