hansva opened a new issue, #9584:
URL: https://github.com/apache/hop/issues/9584

   ### What needs to happen?
   
   The `web-tests` module (Selenium tests for Hop Web) is only listed in the 
root pom inside the opt-in `webtest` profile. `release:prepare` and 
`versions:set` only update modules that are in the active reactor, so a normal 
release run never changes this module's parent version.
   
   That has already happened. The root pom is at `2.21.0-SNAPSHOT`, while 
`web-tests/pom.xml` still declares parent `2.20.0-SNAPSHOT`. With that mismatch 
Maven ignores `relativePath` and looks for `hop:2.20.0-SNAPSHOT` in a 
repository. The nightly `Jenkinsfile.hop-web-selenium` job (`mvn -f 
web-tests/pom.xml test`) can then build the tests against a different parent 
than the one the job just built.
   
   ### Proposed fix
   
   - Always include `web-tests` in the reactor, using a profile that is on by 
default like `config-doc`. `-Dweb-tests=false` takes it out. Version bumps and 
releases then update the module along with the rest of Hop.
   - Skip the module's tests by default. They need Docker and take minutes. 
`-Dwebtest` (or `-Pwebtest`) runs them. The test code still compiles in every 
build, so a broken test fails the build straight away instead of in the nightly 
job.
   - Set the parent version to `2.21.0-SNAPSHOT`.
   - Add `-Dwebtest` to the Maven call in `Jenkinsfile.hop-web-selenium`.
   - Update the build profiles section in the developer manual 
(`build-and-test.adoc`, `getting-started.adoc`).
   
   The one cost is that every build resolves the Selenium and Testcontainers 
test dependencies once. The tests themselves never run unless someone asks for 
them.
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: Integration Testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to