bamaer commented on code in PR #9590:
URL: https://github.com/apache/hop/pull/9590#discussion_r4640927350
##########
plugins/transforms/textchunker/src/main/java/org/apache/hop/pipeline/transforms/chunker/document/metadata/HopMetadataJsonParser.java:
##########
@@ -190,10 +197,14 @@ private static JsonNode redactSecrets(JsonNode node) {
while (names.hasNext()) {
fields.add(names.next());
}
+ boolean secretEntry = isSecretEntry(object, fields);
for (String field : fields) {
JsonNode value = object.get(field);
if (value != null && value.isValueNode()) {
Review Comment:
Fixed: a non-empty list or object under a secret entry is now replaced with
`**redacted**`. Covered by `containerValueOfASecretEntryIsRedacted` and the
`prod-lists` input in IT 0117.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]