hansva commented on code in PR #9620:
URL: https://github.com/apache/hop/pull/9620#discussion_r4652648713


##########
assemblies/static/src/main/resources/config/projects/samples/loops/child-generate-1000-rows.hpl:
##########
@@ -128,7 +128,7 @@ limitations under the License.
       <schema_name/>
     </partitioning>
     <run_configuration>local</run_configuration>
-    <filename>${PROJECT_HOME}/loops/loops-get-rows-from-result.hpl</filename>
+    
<filename>${PROJECT_HOME}/loops/child-loops-get-rows-from-result.hpl</filename>

Review Comment:
   The filename fix is right. The transform's `<name>` (line 120) still reads 
`loops-get-rows-from-result.hpl` though, so the canvas and the logs show a file 
name that no longer exists. Could you rename the transform to 
`child-loops-get-rows-from-result.hpl` (or to a name that doesn't depend on the 
file)?



##########
docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/gettablenames.adoc:
##########
@@ -52,3 +52,7 @@ You can set a default for the timeout field with the 
xref:variables.adoc#_availa
 |Is system object fieldname|Output field containing boolean: is object a 
system object
 |Creation SQL fieldname|Output field containing create statement for object
 |===
+
+== Samples
+
+The samples project has `transforms/get-table-names.hpl`, which lists the 
tables and views of the `hop-samples` connection, with the object type, whether 
it is a system object and, for each table, its `CREATE TABLE` statement.

Review Comment:
   The sample also has `includeProcedure` and `includeSynonym` set to `Y`, so 
it lists procedures and synonyms too, not only tables and views.



##########
docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/fuzzymatch.adoc:
##########
@@ -132,3 +132,10 @@ You can also specify the list of additional fields to 
retrieve from the lookup s
 |===
 
 If no lookup value falls within the configured minimum and maximal range, the 
transform still forwards the main stream row with empty match and measure 
fields.
+
+== Samples
+
+The samples project has:
+
+* `transforms/fuzzy-match-rename.hpl`, which looks up the `name` of a row in 
the `new_name` field of a second Data grid with Jaro-Winkler, and returns the 
lookup fields `new_id` and `new_name` as `user_id` and `user_name`.

Review Comment:
   The sample also returns a third lookup field, `new_address`, under its own 
name. Worth mentioning so the preview output matches the text.



##########
docs/hop-user-manual/modules/ROOT/pages/pipeline/transforms/filterrows.adoc:
##########
@@ -130,9 +130,14 @@ This sample transform gives you all the information, such 
as the values for the
 Alternatively, you can store the .HPL, and then open the .HPL in a text editor.
 3. Find the <condition> element and its nested elements and modify it 
accordingly to use it in your MDI scenario.
 
-== Sample
-The samples project demonstrates some concepts in file "filter-rows-basic.hpl".
+== Samples
 
+The samples project has:
+
+* `transforms/filter-rows-basic.hpl`, which checks 10 rows from a Data grid 
against `(id < 5 OR group = GR03) AND NOT desc = d`: one Filter rows sends the 
5 matching rows to one Dummy and the other 5 to another, and the second one 
only passes on the 5 matching rows.
+* `metadata-injection/filter-rows-mdi-parent.hpl`, which injects the condition 
shown under <<MDI Example>> into the Filter rows of 
`metadata-injection/filter-rows-mdi-child.hpl`, which reads 
`files/customers-100.txt`.

Review Comment:
   The sentence under MDI Example (line 146) already names 
`filter-rows-mdi-parent.hpl` and `filter-rows-mdi-child.hpl`, so the page now 
points to them twice. Maybe keep one and refer to it from the other, so a later 
rename only needs one update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to