hansva opened a new issue, #9639:
URL: https://github.com/apache/hop/issues/9639

   ### What needs to happen?
   
   hop-core declares 20 `io.grpc` artifacts that no class in hop-core, 
hop-engine or hop-ui
   uses. They are there so the Beam, Google and Arrow Flight plugins can share 
one copy in
   `lib/core`. They add about 45 MB to every install, including installs 
without any of those
   plugins.
   
   ### Proposal
   
   - **gRPC ships with the plugins that use it.** hop-core drops the `io.grpc` 
artifacts.
     Beam, Google and Arrow each ship the gRPC jars their own libraries need, 
in `lib/core`.
     hop-libs imports `grpc-bom`, so every module resolves one gRPC version.
   - **Plugins that relied on the gRPC side effects ship what they use.** gRPC 
also brought
     netty, protobuf-java and re2j into `lib/core`, and several plugins 
depended on that
     without declaring it:
     - AWS and Redshift: the netty HTTP client.
     - Cassandra, FalkorDB, Redis, Calcite and Gremlin: netty.
     - Spark: netty and protobuf. Spark also never shipped the lz4-java it 
declares.
     - Lakehouse and Parquet: re2j, which Hadoop's `GlobPattern` uses.
     
     Each of these plugins now pins what it uses as `provided`, so its zip puts 
it in
     `lib/core`.
   - **Driver download keeps MySQL working.** The MySQL driver download 
excluded protobuf-java
     because `lib/core` always had it. It now downloads protobuf-java with the 
driver, at
     Hop's version instead of the one Connector/J declares. To make that 
possible, a driver's
     transitive dependencies can be pinned to Hop's versions (`DriverDownload` 
managed
     versions), and the protobuf-java version moves to the root pom.
   - **hop-core declares jsr305** itself. `RowMeta` and `ValueMetaBase` use
     `javax.annotation.Nullable`, which until now only arrived through gRPC.
   
   ### Result
   
   - A client without plugins drops the gRPC jars and their libraries.
   - The full client keeps the same gRPC jars, now through the Google plugin, 
apart from four
     that nothing bundled needs.
   - Every affected plugin was checked on its own, on a client without other 
plugins.
   
   The Spark-native, Iceberg, Lakehouse, MySQL and Beam integration tests pass 
on such
   minimal installs.
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: Transforms


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to