[ 
https://issues.apache.org/jira/browse/HTRACE-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236144#comment-14236144
 ] 

Colin Patrick McCabe commented on HTRACE-7:
-------------------------------------------

After this patch, the htrace-core jar file contains shaded versions of Guava 
and Jetty:

{code}
jar tvf ./htrace-core-3.0.4.jar | less
     0 Fri Dec 05 13:11:18 PST 2014 META-INF/
   132 Fri Dec 05 13:11:18 PST 2014 META-INF/MANIFEST.MF
     0 Fri Dec 05 13:11:18 PST 2014 org/
     0 Fri Dec 05 13:11:18 PST 2014 org/htrace/
   983 Fri Dec 05 13:11:18 PST 2014 org/htrace/TraceInfo.class
   555 Fri Dec 05 13:11:18 PST 2014 org/htrace/Tracer$TracerHolder.class
...
  2513 Fri Dec 05 13:11:18 PST 2014 
org/apache/htrace/google/common/primitives/SignedBytes.class
  4230 Fri Dec 05 13:11:18 PST 2014 
org/apache/htrace/google/common/primitives/Longs$LongArrayAsList.class
  1935 Fri Dec 05 13:11:18 PST 2014 
org/apache/htrace/google/common/primitives/UnsignedLongs$LexicographicalComparator.class
   239 Fri Dec 05 13:11:18 PST 2014 
org/apache/htrace/google/common/primitives/package-info.class
...
  4137 Fri Dec 05 13:11:20 PST 2014 
org/apache/htrace/mortbay/thread/Timeout.class
  3421 Fri Dec 05 13:11:20 PST 2014 
org/apache/htrace/mortbay/thread/QueuedThreadPool$PoolThread.class
   252 Fri Dec 05 13:11:20 PST 2014 
org/apache/htrace/mortbay/thread/QueuedThreadPool$1.class
   342 Fri Dec 05 13:11:20 PST 2014 
org/apache/htrace/mortbay/thread/ThreadPool.class
  7609 Fri Dec 05 13:11:20 PST 2014 
org/apache/htrace/mortbay/thread/BoundedThreadPool.class
   942 Fri Dec 05 13:11:20 PST 2014 
org/apache/htrace/mortbay/thread/QueuedThreadPool$Lock.class
...
{code}

> htrace-core should shade its dependencies to avoid leaking them on to client 
> CLASSPATH
> --------------------------------------------------------------------------------------
>
>                 Key: HTRACE-7
>                 URL: https://issues.apache.org/jira/browse/HTRACE-7
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-7.001.patch
>
>
> htrace-core should shade its dependencies to avoid leaking them on to client 
> CLASSPATH.  This is particularly a problem with Hadoop.  We do not want our 
> versions of Guava and Jetty to fight with Hadoop's versions (and different 
> versions of Hadoop have different ones.)  Luckily, this can be fixed very 
> easily just by shading our dependencies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to