[ 
https://issues.apache.org/jira/browse/HTRACE-2?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241668#comment-14241668
 ] 

Colin Patrick McCabe commented on HTRACE-2:
-------------------------------------------

Yeah, I did think about that a bit.  There are a few differences... like this 
one returns Sampler.NEVER instead of returning null, uses a different LOG, 
different conf key, etc.  Maybe we'll spot some stuff we can pull out or share 
later... for now it's a short file and it doesn't seem that big a deal.

It will be nice to cut all that "let's guess the sampler name" stuff out of 
Hadoop.

> HTrace should have a factory method for creating trace samplers
> ---------------------------------------------------------------
>
>                 Key: HTRACE-2
>                 URL: https://issues.apache.org/jira/browse/HTRACE-2
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: 0001-HTRACE-2.patch, HTRACE-2.002.patch
>
>
> HTrace should have a factory method for creating trace samplers.  Similar 
> rationale to HTRACE-1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to