[
https://issues.apache.org/jira/browse/HTRACE-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243038#comment-14243038
]
Colin Patrick McCabe commented on HTRACE-13:
--------------------------------------------
Moving HTraceSpanReceiver into htrace-hbase seems like a good idea, +1 for that
{code}
29 public class HBaseHTraceConfiguration extends HTraceConfiguration {
30 public static final String KEY_PREFIX = "hbase.";
{code}
Hmm. I think maybe we should use {{hbase.htrace}} as the prefix. Hadoop is
using {{hadoop.htrace}}, so that seems to fit. So if you want your HDFS to
write trace spans to the local /foo/bar file, you set
{{hadoop.htrace.local-file-span-receiver.path}} to {{/foo/bar}}. If you want
your HBase to send spans to /foo/baz, you set
{{hbase.htrace.local-file-span-receiver.path}} to {{/foo/baz}}.
Using just "hbase" as a prefix is kinda weird because it would be
{{hbase.local-file-span-receiver.path}}, which suggests it's an hbase thing,
not an htrace thing... right?
bq. Changed the 'build' method name to 'create'. When its 'build' i kept adding
Builder pattern methods but this is a factory. Added extra 'create' that takes
String of class to use creating an instance.
Sorry, this is my bad I suppose. I intended this to be a Builder, but I called
it a Factory. Can you rename it to {{SpanReceiverBuilder}} perhaps? I really
don't want to start overloading the create method... when I look at the zillion
different file create overload methods in Hadoop's FileSystem.java, it just
makes me want to cry. Let's not go down that path in our public API
> Fix htrace-hbase circular dependencies
> --------------------------------------
>
> Key: HTRACE-13
> URL: https://issues.apache.org/jira/browse/HTRACE-13
> Project: HTrace
> Issue Type: Task
> Reporter: stack
> Assignee: stack
> Attachments: htrace-13.txt
>
>
> Post import, to make it so all build after redoing our package from
> org.htrace to org.apache.htrace, we commented out some interesting circular
> references that were going on between trace classes in hbase and then
> htrace-hbase's This issue is about commenting in the commented out code and
> removing the circular dependency.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
