[ 
https://issues.apache.org/jira/browse/HTRACE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264086#comment-14264086
 ] 

Colin Patrick McCabe commented on HTRACE-30:
--------------------------------------------

Setting {{content-type/json}} seems like a good idea here, I will do that.

I think the URLs are fine as-is but I don't have a strong preference.  If you 
want to put everything under a prefix, maybe we could use {{/js}}?  It should 
be a short prefix since we'll end up sending it over the wire a lot.

bq. b\[0\] != DOUBLE_QUOTE is required?

SpanIDs are always serialized as JSON strings.  This piece of code is a custom 
JSON parser for span ids.  It gets handed the field, which includes the quotes 
around the data.  I think checking that the first and last characters are 
quotes is a good practice here, since otherwise we could fail in mysterious 
ways on sloppy JSON.  Keep in mind, we cannot use "numbers" here since we need 
the full 64 bits, not the 55 bits of precision that Javascript uses for numbers.

bq. Where we going to write up the REST spec? We need to start a markdown doc 
describing the REST htraced digests? Or that later after REST vocabulary 
settles? Probably better if the htraced serves up a page of the REST vocabulary 
if you pass ?help or something?

{{?help}} sounds like a very good idea  I think we should do it after the 
vocabulary settles a little bit.

> Add writeSpan REST verb to htraced
> ----------------------------------
>
>                 Key: HTRACE-30
>                 URL: https://issues.apache.org/jira/browse/HTRACE-30
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-30.001.patch, HTRACE-30.002.patch
>
>
> Add a /writeSpan REST verb to htraced so that we can create spans, as well as 
> query them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to