[
https://issues.apache.org/jira/browse/HTRACE-52?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264766#comment-14264766
]
Colin Patrick McCabe commented on HTRACE-52:
--------------------------------------------
The uint stuff is needed to ensure that we can pass in spans as 16-digit
unsigned hex numbers to the htrace command. Previously it was giving a range
error on numbers bigger than 2**63.
bq. cmd.go should send content-type?
Good point, will add.
bq. htraced doesn't do keepalive, does it? If no content-type, you try and
digest as json and throw back parse exception it seems – thats good.
No, we don't do keepalive. Sounds good
> FIgure out content-type handling in JSON API
> --------------------------------------------
>
> Key: HTRACE-52
> URL: https://issues.apache.org/jira/browse/HTRACE-52
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-52.001.patch
>
>
> We should figure out how to handle content-type in the JSON API. We should
> definitely be setting {{Content-Type}} as {{application/json}} when writing
> data.
> I guess a secondary question is whether the server should reject calls to
> APIs like {{/writeSpan}} if Content-Type is set incorrectly. I'm not sure if
> this adds any value... thoughts?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
