[
https://issues.apache.org/jira/browse/HTRACE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki updated HTRACE-33:
-----------------------------------
Attachment: HTRACE-33.002.patch
Thanks for the review comments. I updated the patch.
bq. Instead of reading /proc/self/stat, I think we should call
Tracer#getProcessId for this.
The return value of {{Tracer#getProcessId}} may not be unique enough because it
is a short name of main class.
bq. we should test that we can open and write to one of these files.
I added test writing span to local file by LocalFileSpanReciever.
> Add getUniqueLocalTraceFileName to LocalFileSpanReceiver
> --------------------------------------------------------
>
> Key: HTRACE-33
> URL: https://issues.apache.org/jira/browse/HTRACE-33
> Project: HTrace
> Issue Type: Improvement
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Attachments: HTRACE-33.001.patch, HTRACE-33.002.patch
>
>
> o.a.hadoop.tracing.SpanReceiverHost#getUniqueLocalTraceFileName of Hadoop
> should belong to HTrace. Add it to HTrace first then remove it from Hadoop on
> the next bumping of HTrace version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
