[
https://issues.apache.org/jira/browse/HTRACE-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14267802#comment-14267802
]
Colin Patrick McCabe commented on HTRACE-33:
--------------------------------------------
Yeah, you're right, {{Tracer#getProcessId}} won't be unique if we are running
multiple daemons with the same main class id, like multiple datanodes. I still
feel that we might want to think about eventually including it in the file name
to make for a more "friendly" name for devs doing testing. But we can do that
in a follow-on change.
bq. I added test writing span to local file by LocalFileSpanReciever.
thanks.
+1
> Add getUniqueLocalTraceFileName to LocalFileSpanReceiver
> --------------------------------------------------------
>
> Key: HTRACE-33
> URL: https://issues.apache.org/jira/browse/HTRACE-33
> Project: HTrace
> Issue Type: Improvement
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Priority: Minor
> Attachments: HTRACE-33.001.patch, HTRACE-33.002.patch
>
>
> o.a.hadoop.tracing.SpanReceiverHost#getUniqueLocalTraceFileName of Hadoop
> should belong to HTrace. Add it to HTrace first then remove it from Hadoop on
> the next bumping of HTrace version.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
