[ 
https://issues.apache.org/jira/browse/HTRACE-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270328#comment-14270328
 ] 

stack commented on HTRACE-58:
-----------------------------

I'd filed an issue with Units but must have been your mail that did it Billie.  
I actually included the UNITs license additions as an addendum on what I 
committed:

kalashnikov-2:incubator-htrace stack$ git show -1
commit 9534eff4db9988f44d8d9335236abc173a12bb43
Author: stack <[email protected]>
Date:   Thu Jan 8 16:35:35 2015 -0800

    HTRACE-58 Address Billie Rinaldi feedback on RC4 of 3.1.0; ADDENDUM for 
UNITS Lib

diff --git a/LICENSE.txt b/LICENSE.txt
index abd9f26..cbea1db 100644
--- a/LICENSE.txt
+++ b/LICENSE.txt
@@ -207,9 +207,12 @@ of dependencies that are NOT Apache Licensed.
 levigo, a go wrapper for leveldb, is Copyright (c) 2012 Jeffrey M Hodges
 and MIT licensed: https://github.com/jmhodges/levigo/blob/master/LICENSE

-Kingpin, a go command line and flag parser is Copyright (c) 2014 Alec Thomas
+Kingpin, a go command line and flag parser, is Copyright (c) 2014 Alec Thomas
 and MIT licensed: https://github.com/alecthomas/kingpin/blob/master/COPYING

+Units, a string formatting go library, is Copyright (c) 2014 Alec Thomas
+and MIT licensed: https://github.com/alecthomas/units/blob/master/COPYING
+
 D3, a javascript library for manipulating data, used by htrace-hbase
 is Copyright 2010-2014, Michael Bostock and BSD licensed:
 https://github.com/mbostock/d3/blob/master/LICENSE

Thanks [~billie.rinaldi] for the review.  I went ahead and posted a new RC.

> Address Billie Rinaldi feedback on RC4 of 3.1.0
> -----------------------------------------------
>
>                 Key: HTRACE-58
>                 URL: https://issues.apache.org/jira/browse/HTRACE-58
>             Project: HTrace
>          Issue Type: Task
>            Reporter: stack
>            Assignee: stack
>             Fix For: 3.1.0, master
>
>         Attachments: 
> 0001-HTRACE-58-Address-Billie-Rinaldi-feedback-on-RC4.patch, 58v2.txt
>
>
> See dev mailing list VOTE on 3.1.0RC4 for comprehensive feedback on our RC by 
> Billie Rinaldi. Address here feedback.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to