[
https://issues.apache.org/jira/browse/HTRACE-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283421#comment-14283421
]
Colin Patrick McCabe commented on HTRACE-78:
--------------------------------------------
Thanks, Abe. This looks pretty good!
Just to be clear, typing the date remains an option here, correct?
{code}
31 var startdate = $(this.el).find("#begindate").val();// ||
now.format("D MMMM, YYYY");
32 var starttime = $(this.el).find("#begintime").val() ||
now.format("H:mm A");
33 var enddate = $(this.el).find("#stopdate").val();// ||
now.format("D MMMM, YYYY");
34 var endtime = $(this.el).find("#stoptime").val() ||
now.format("H:mm A");
{code}
Can we harmonize the naming here a bit? I.e. use "begindate" everywhere rather
than mixing "start" and "begin"
> Search page: Enhance begin time and end time selection widget
> -------------------------------------------------------------
>
> Key: HTRACE-78
> URL: https://issues.apache.org/jira/browse/HTRACE-78
> Project: HTrace
> Issue Type: Sub-task
> Reporter: Abraham Elmahrek
> Assignee: Abraham Elmahrek
> Attachments: HTRACE-78.0.patch, HTRACE-78.1.patch, Screenshot
> 2015-01-19 21.29.26.png, Screenshot 2015-01-19 21.29.30.png
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
