stack created HTRACE-85:
---------------------------

             Summary: Feedback from Justin McClean over in general@incubator 
htrace RC vote
                 Key: HTRACE-85
                 URL: https://issues.apache.org/jira/browse/HTRACE-85
             Project: HTrace
          Issue Type: Bug
            Reporter: stack
            Assignee: stack
            Priority: Critical


>From Justin's feedback on the RC:

{code}

Minor LICENSE issues:
While levigo is used it doesn't seem to be bundled so there's no need to add it 
to LICENSE. Same (I think) with kingpin,  gorilla and godep. If it not bundled 
there's no need for it to mentioned in LICENSE. [1] Can you double check that 
there are bundled in the source release and if not remove their sections from 
LICENSE.

Minor NOTICE issue:
No need to have zipkin mentioned at it is Apache licensed and it's (incorrect) 
NOTICE file contains nothing that needs to be added here. [2]

Slightly less minor NOTICE issue is that it is missing this text at the top: [3]

Apache [PRODUCT_NAME]
Copyright [XXXX-20XX] The Apache Software Foundation

{code}

Let me fix these before we do our next release (Justin was good w/ this).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to