[ 
https://issues.apache.org/jira/browse/HTRACE-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14284532#comment-14284532
 ] 

Colin Patrick McCabe commented on HTRACE-51:
--------------------------------------------

bq. Nice review. Will address. Will hadoop always be in the mix doing the 
htrace.client? I think having htraced in the name of the client is a bit odd. 
Its the client. I could do htraced.client.rest.timeout.ms? Will make a 
htraced.rest.url that takes http://localhost:9095 by default (we can support 
https in client with a config).

How about just "client.rest.timeout.ms"?  If we later add another type of span 
receiver that does REST requests, we can have it use the same key for its 
timeout :)

bq. Will make a htraced.rest.url that takes http://localhost:9095 by default 
(we can support https in client with a config).

Nice.  This key is really specific to the htraced span receiver so I think 
that's a good name

bq. Forgot to say, I liked the previous review too, especially the "I think we 
ought to put an upper limit on the number of spans we'll send in a single 
request."

thanks

> htraced java REST client (a.k.a java SpanReceiver for htraced)
> --------------------------------------------------------------
>
>                 Key: HTRACE-51
>                 URL: https://issues.apache.org/jira/browse/HTRACE-51
>             Project: HTrace
>          Issue Type: New Feature
>            Reporter: stack
>            Assignee: stack
>         Attachments: 51.txt, 51.txt, 52v2.txt
>
>
> Add a java REST client for htraced so we can build a receiver that writes 
> htraced via REST from a java process.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to