[ 
https://issues.apache.org/jira/browse/HTRACE-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292597#comment-14292597
 ] 

stack commented on HTRACE-89:
-----------------------------

No line number and no originating class! (smile)

We'll add test for log level later so we don't compose String each time:        
                lg.Tracef("Shard processor for %s wrote span %s.\n", shd.path, 
span.ToJson())

I can't change log level dynamically?

This stuff is related to this patch?

                store.shards[idx] = nil

lg is ugly name... why not just call it logger so plain what it is.

Otherwise, patch looks good. +1. Lets get it in. We can make it fancier later.


> htraced: add log levels, writing to log files
> ---------------------------------------------
>
>                 Key: HTRACE-89
>                 URL: https://issues.apache.org/jira/browse/HTRACE-89
>             Project: HTrace
>          Issue Type: New Feature
>    Affects Versions: 3.2.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HTRACE-89.001.patch
>
>
> htraced should have log levels and the ability to write to log files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to