[
https://issues.apache.org/jira/browse/HTRACE-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299513#comment-14299513
]
stack commented on HTRACE-90:
-----------------------------
+1
Great.
> Remove Guava and shade other depdendencies in HTrace subprojects
> ----------------------------------------------------------------
>
> Key: HTRACE-90
> URL: https://issues.apache.org/jira/browse/HTRACE-90
> Project: HTrace
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-90.001.patch
>
>
> We should remove Guava and shade the other depdendencies in the HTrace
> subprojects.
> * protobuf: *must* be shaded. Hadoop and HBase pull in their own version--
> there's no guarantee that it will be the same as ours. And protobuf broke
> cross-version compatibility in the past (i.e. during the 2.4 -> 2.5
> transition)
> * Apache Thrift: should be shaded. We don't want to fight with the host
> application about versions of Thrift.
> * Guava: should be removed. We hardly use it at all, and its cross-version
> compatibility policy is a mess.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
