[
https://issues.apache.org/jira/browse/HTRACE-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299625#comment-14299625
]
Samarth Jain commented on HTRACE-101:
-------------------------------------
Thanks for the patch [~cmccabe]. +1 on the new comments. For the places at
which you are throwing Tracer.clientError(), I would advocate for resetting the
thread local storing the current span by doing Tracer.continueSpan(null). In
case of such errors, we should be safe and reset the thread local. Otherwise it
would still result in potentially catastrophic conditions like the one we
addressed in PHOENIX-1596. What do you think?
> Add better error-checking to Java HTrace client
> -----------------------------------------------
>
> Key: HTRACE-101
> URL: https://issues.apache.org/jira/browse/HTRACE-101
> Project: HTrace
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-101.001.patch
>
>
> The Java HTrace client should have better error-checking. This will make it
> easier for applications to use the API correctly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
