[
https://issues.apache.org/jira/browse/HTRACE-103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308570#comment-14308570
]
Colin Patrick McCabe commented on HTRACE-103:
---------------------------------------------
Sorry, I wanted to review this earlier but I got swamped by some other stuff.
Maybe let's just keep the APIs the same for now, and think about adding new
ones in another JIRA. I do think it's inconvenient that the unit tests are
broken (and it's my fault, too :P )
I am +1 for the current patch, except for this line:
{code}
s = Trace.startSpan("shouldNotBeStarted", sampler, -1);
{code}
I think this was an experiment that got left in accidentally?
thanks, [~iwasakims].
> testHtrace and testParamterizedSampler fails
> --------------------------------------------
>
> Key: HTRACE-103
> URL: https://issues.apache.org/jira/browse/HTRACE-103
> Project: HTrace
> Issue Type: Bug
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Attachments: HTRACE-103.001.patch
>
>
> {noformat}
> testHtrace(org.apache.htrace.TestHTrace) Time elapsed: 6.085 sec <<<
> FAILURE!
> java.lang.AssertionError: Trace tree must have roots
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.apache.htrace.TestHTrace.testHtrace(TestHTrace.java:81)
> testParamterizedSampler(org.apache.htrace.TestSampler) Time elapsed: 0.001
> sec <<< FAILURE!
> java.lang.AssertionError: expected null, but
> was:<{"i":"b26e533db550abdd","s":"91d90044ecab5eb8","b":1423065328326,"e":0,"d":"test","r":"jar","p":["73e962f3b7140c54"]}>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotNull(Assert.java:664)
> at org.junit.Assert.assertNull(Assert.java:646)
> at org.junit.Assert.assertNull(Assert.java:656)
> at
> org.apache.htrace.TestSampler.testParamterizedSampler(TestSampler.java:60)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
