[
https://issues.apache.org/jira/browse/HTRACE-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335850#comment-14335850
]
Colin Patrick McCabe commented on HTRACE-104:
---------------------------------------------
bq. htrace-core/src/go/src/org/apache/htrace/client/client.go#164: I'm a bit
naive here, but are span IDs guarantee to be a positive number? If so, I feel
like we should be using uint64 every where.
span ids are currently a user-defined type defined in span.go. But you're
right that they should be defined in terms of uint64 rather than int64 (but
that is outside the scope of this patch).
bq. htrace-core/src/go/src/org/apache/htrace/common/query.go#63: Valid ops is
listed twice. Not a big deal though. Same is true for field. It seems like
golang is lacking a library function for testing the existence of an object in
an array of objects.
I guess I should probably iterate through the array, that would be a bit
cleaner. Yeah, let me do that.
bq. htrace-core/src/go/gobuild.sh: Just making sure the modifications to this
file is intended?
Yeah, as described above, just wanted to make the \-v optional.
bq. htrace-core/src/go/src/org/apache/htrace/htrace/cmd.go: Why not keep some
base ops (ie: dump/load/graph/query) and just have options on these ops (ie:
-all)?
It's easier to have different commands. Otherwise we have to validate which
combinations of options are valid (specifying both \-\-file and \-\-json
doesn't work, etc. etc.) Also it's more typing.
bq. Awesome dot graph generation! Does https://code.google.com/p/gographviz/
not work?
It looks like a nice library, but it hasn't been updated since May 2014.
Honestly, the code to actually emit the graphviz file is like 5 lines... it
really seems like overkill to add another dependency for this. The code which
takes up more lines is building a map from spans to their children, which we
would have to do in any case. If we run into things which would be easier to
do with a library, we can always revisit this.
> htrace command should support generating graphviz files and making htraced
> queries
> ----------------------------------------------------------------------------------
>
> Key: HTRACE-104
> URL: https://issues.apache.org/jira/browse/HTRACE-104
> Project: HTrace
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-104.001.patch, HTRACE-104.002.patch
>
>
> The htrace command should support generating graphviz files and making
> htraced queries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
