[
https://issues.apache.org/jira/browse/HTRACE-125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344010#comment-14344010
]
Colin Patrick McCabe commented on HTRACE-125:
---------------------------------------------
oops, had to add this to fix a unit test:
{code}
diff --git a/htrace-core/src/go/src/org/apache/htrace/conf/config_test.go
b/htrace-core/src/go/src/org/apache/htrace/conf/config_test.go
index 1e94ed7..42c1c71 100644
--- a/htrace-core/src/go/src/org/apache/htrace/conf/config_test.go
+++ b/htrace-core/src/go/src/org/apache/htrace/conf/config_test.go
@@ -20,6 +20,7 @@
package conf
import (
+ "bytes"
"os"
"strings"
"testing"
@@ -124,12 +125,13 @@ func TestXmlConfigurationFile(t *testing.T) {
// Test our handling of the HTRACE_CONF_DIR environment variable.
func TestGetHTracedConfDirs(t *testing.T) {
os.Setenv("HTRACED_CONF_DIR", "")
- dirs := getHTracedConfDirs()
+ dlog := new(bytes.Buffer)
+ dirs := getHTracedConfDirs(dlog)
if len(dirs) != 1 || dirs[0] != "." {
t.Fatal()
}
os.Setenv("HTRACED_CONF_DIR", "/foo/bar:/baz")
- dirs = getHTracedConfDirs()
+ dirs = getHTracedConfDirs(dlog)
if len(dirs) != 2 || dirs[0] != "/foo/bar" || dirs[1] != "/baz" {
t.Fatal()
}
{code}
all is well after that, though. thanks, committed to 3.2
> htraced: log when htraced terminates on a signal, and optionally log
> configuration when starting up
> ---------------------------------------------------------------------------------------------------
>
> Key: HTRACE-125
> URL: https://issues.apache.org/jira/browse/HTRACE-125
> Project: HTrace
> Issue Type: Improvement
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-125.001.patch
>
>
> htraced: log when htraced terminates on a signal, and optionally log
> configuration when starting up
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
