[ 
https://issues.apache.org/jira/browse/HTRACE-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14350843#comment-14350843
 ] 

Colin Patrick McCabe commented on HTRACE-132:
---------------------------------------------

Yeah, I wish Java had something like Scala's "project-private" access level.  
Or I wish that we had just kept everything in the same package :)

Maybe eventually I'll write a nicer random implementation and feel OK about 
making it public.  I was thinking maybe something that reads from 
{{/dev/urandom}} and does thread-local caching... maybe.

Committed, thanks

> Trace#startSpan(String, TraceInfo) creates spans with spanId == 0
> -----------------------------------------------------------------
>
>                 Key: HTRACE-132
>                 URL: https://issues.apache.org/jira/browse/HTRACE-132
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Blocker
>         Attachments: 
> 0001-HTRACE-132.-Trace-startSpan-String-TraceInfo-creates.patch
>
>
> {{Trace#startSpan(String description, TraceInfo tinfo)}} creates spans with 
> spanId == 0.  It should create spans with a random nonzero ID, like the other 
> {{startSpan}} functions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to