[ 
https://issues.apache.org/jira/browse/HTRACE-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353432#comment-14353432
 ] 

Colin Patrick McCabe commented on HTRACE-134:
---------------------------------------------

My quick read of this patch is that it's not adding new functionality to the 
UI, but just adding in Marionette.  I read a little bit about Marinotte here: 
http://benmccormick.org/2014/12/02/the-case-for-marionette-js/ and it sounds 
good.

I noticed a few places where we switch from single quotes to double quotes, 
seems like we could trim those from the patch to make it smaller and more 
readable.

+1 can fix on commit.  Can you file a follow-on JIRA for the stuff [~mayang] 
pointed out?

> Port front end to marionette JS
> -------------------------------
>
>                 Key: HTRACE-134
>                 URL: https://issues.apache.org/jira/browse/HTRACE-134
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>              Labels: ui
>             Fix For: 3.2.0
>
>         Attachments: HTRACE-134.001.patch
>
>
> Add marionette support



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to