[ 
https://issues.apache.org/jira/browse/HTRACE-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14381116#comment-14381116
 ] 

Masatake Iwasaki commented on HTRACE-142:
-----------------------------------------

I still have problem when I see details view of the span which have no 
children. Graph does not work after moving back from the details view.

Here is comments for 003.
---
{noformat}
--- a/htrace-core/src/web/app/setup.js
+++ b/htrace-core/src/web/app/setup.js
@@ -38,6 +38,17 @@ var Router = Backbone.Marionette.AppRouter.extend({
     // Collection
     this.spansCollection = new app.Spans();
     this.spansCollection.fetch();
+
+    // Views
+    this.graphView = new app.GraphView({
+      "collection": this.spansCollection,
+      "id": "span-graph"
+    });
+  },
{noformat}
GraphView initialized here seems not to be used.

---
{noformat}
+        = d3.layout.force().size([$(window).width(), $(window).height() * 3/4])
+                           // .alpha(0.1)
+                           .linkDistance($(window).height() / 5)
+                           .charge(-120)
+                           // .linkDistance(150)
+                           // .linkStrength(1)
+                           // .friction(0.2)
+                           .gravity(0)
{noformat}
{noformat}
+    var path = selection.enter().append("path")
+        .classed("link", true)
+    // var line = selection.enter().append("line")
+    //     .classed("link", true)
+        .style("marker-end",  "url(#suit)");
{noformat}
These commenting out should be cleaned up before commit.


> Details page: Update graph
> --------------------------
>
>                 Key: HTRACE-142
>                 URL: https://issues.apache.org/jira/browse/HTRACE-142
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>             Fix For: 3.2.0
>
>         Attachments: HTRACE-142.001.patch, HTRACE-142.002.patch, 
> HTRACE-142.003.patch
>
>
> Details page graph general updates. This should have gone in HTRACE-121, but 
> sadly didn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to