[
https://issues.apache.org/jira/browse/HTRACE-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384354#comment-14384354
]
Colin Patrick McCabe commented on HTRACE-69:
--------------------------------------------
HTrace is supposed to trace a complete operation from the start to the finish.
If we start leaving out parts of the operation, we're no longer meeting that
goal.
If we find that we have too many trace spans, it seems like the solution is to
reduce the sampling rate (it should be less than 1%) or to fix the program that
is being traced to no longer generate trace spans that are not interesting. I
think we will need to do some experimentation to see which trace spans are
truly useful.
> Filtering child spans by sampler
> --------------------------------
>
> Key: HTRACE-69
> URL: https://issues.apache.org/jira/browse/HTRACE-69
> Project: HTrace
> Issue Type: New Feature
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
>
> Trace#startSpan respect the sampler given as argument only when there is no
> ongoing span (i.e. when creating new root span).
> {code}
> public static TraceScope startSpan(String description, Sampler<TraceInfo>
> s, TraceInfo tinfo) {
> Span span = null;
> if (isTracing() || s.next(tinfo)) {
> {code}
> Adding API starting span if {{(isTracing() && s.next(tinfo))}} enables
> filtering of child spans.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
