[
https://issues.apache.org/jira/browse/HTRACE-151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507732#comment-14507732
]
Colin Patrick McCabe edited comment on HTRACE-151 at 4/22/15 10:18 PM:
-----------------------------------------------------------------------
OK, I tried this, and got a bunch of "class not found" errors. I'm not sure
why HTRACE-148 worked, but this doesn't. \[update: HTRACE-148 did not work\].
Perhaps it has something to do with the fact that maven shade is run during the
package phase, and the compile phase comes before package?
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project htrace-core: Compilation failure: Compilation failure:
[ERROR]
/home/cmccabe/src/htrace2/htrace-core/src/main/java/org/apache/htrace/impl/MilliSpan.java:[22,47]
error: package org.apache.htrace.fasterxml.jackson.core does not exist
[ERROR]
/home/cmccabe/src/htrace2/htrace-core/src/main/java/org/apache/htrace/impl/MilliSpan.java:[23,47]
error: package org.apache.htrace.fasterxml.jackson.core does not exist
[ERROR]
/home/cmccabe/src/htrace2/htrace-core/src/main/java/org/apache/htrace/impl/MilliSpan.java:[24,51]
error: package org.apache.htrace.fasterxml.jackson.databind does not exist
{code}
was (Author: cmccabe):
OK, I tried this, and got a bunch of "class not found" errors. I'm not sure
why HTRACE-148 worked, but this doesn't. Perhaps it has something to do with
the fact that maven shade is run during the package phase, and the compile
phase comes before package?
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile)
on project htrace-core: Compilation failure: Compilation failure:
[ERROR]
/home/cmccabe/src/htrace2/htrace-core/src/main/java/org/apache/htrace/impl/MilliSpan.java:[22,47]
error: package org.apache.htrace.fasterxml.jackson.core does not exist
[ERROR]
/home/cmccabe/src/htrace2/htrace-core/src/main/java/org/apache/htrace/impl/MilliSpan.java:[23,47]
error: package org.apache.htrace.fasterxml.jackson.core does not exist
[ERROR]
/home/cmccabe/src/htrace2/htrace-core/src/main/java/org/apache/htrace/impl/MilliSpan.java:[24,51]
error: package org.apache.htrace.fasterxml.jackson.databind does not exist
{code}
> htrace-core, htrace-htraced: Use shaded import paths
> ----------------------------------------------------
>
> Key: HTRACE-151
> URL: https://issues.apache.org/jira/browse/HTRACE-151
> Project: HTrace
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Fix For: 3.2.0
>
>
> We should use the shaded import paths for htrace-core and htrace-htraced, to
> make sure we're using the shaded classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
