[
https://issues.apache.org/jira/browse/HTRACE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509988#comment-14509988
]
Colin Patrick McCabe commented on HTRACE-148:
---------------------------------------------
Thanks again, [~iwasakims]. It's frustrating that this problem only seems to
appear for you (I've never seen it.)
Can you make the {{MilliSpan#fromJson}} method package-private instead of
public? We'd have to think about it more if we wanted a fully public
interface, I think. Deserializing from a string is less efficient than some of
the other interfaces we could have. Since this function is just called by unit
tests in the same package, I guess we don't need to make it public.
Looks good aside from that.
> TestHTracedRESTReceiver should use the shaded ObjectMapper to avoid
> TestHTracedRESTReceiver failure
> ---------------------------------------------------------------------------------------------------
>
> Key: HTRACE-148
> URL: https://issues.apache.org/jira/browse/HTRACE-148
> Project: HTrace
> Issue Type: Bug
> Reporter: Masatake Iwasaki
> Assignee: Masatake Iwasaki
> Fix For: 3.2.0
>
> Attachments: HTRACE-148.001.patch, HTRACE-148.002.patch,
> HTRACE-148.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
