[
https://issues.apache.org/jira/browse/HTRACE-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522059#comment-14522059
]
Colin Patrick McCabe commented on HTRACE-162:
---------------------------------------------
* When running ./bin/htrace during the native unit tests, the log output should
go to a separate file, rather than appearing in the htraced.log. Having the
htrace command log output appear in the htraced log is just confusing.
* common/log.go: make the API for writing a given string at a given log level
public. (i.e. {{Logger#Write}}) It's useful for conditionally changing the
log level of messages.
* {{htraced/hrpc.go}}: When we get an EOF (end of file) reading the HRPC
header, log it at Debug level. This is a normal occurrence if the client goes
away. All it indicates is that we aren't sending another message. Note that
if we get an EOF at the middle of the HRPC message, we still log that at WARN
level since it indicates a partial message was sent.
> htraced hrpc: some logging improvements
> ---------------------------------------
>
> Key: HTRACE-162
> URL: https://issues.apache.org/jira/browse/HTRACE-162
> Project: HTrace
> Issue Type: Improvement
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-162.001.patch
>
>
> Some logging improvements to htraced hrpc, as suggested on HTRACE-159. The
> biggest one is lowering the log level of EOF when reading the HRPC header.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
