[
https://issues.apache.org/jira/browse/HTRACE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529225#comment-14529225
]
Elliott Clark commented on HTRACE-164:
--------------------------------------
bq.This is just an internal implementation detail of the htraced daemon. If you
don't like msgpack, you can simply not use the htraced daemon.
I can't use the library either if their rpc is tied together.
I think static linking would be better (that pushes the work onto the htrace
devs rather than the users).
However I still think it's really bad to include another serialization format
and to write our own rpc. There's just nothing that's complex enough of
performance sensitive enough about this to justify the added complexity. The
hadoop world has settled on protobuf. Unless something is unworkable with
protobuf then I don't see using anything else. Most hadoop/hbase ( where htrace
will be used most often for now) installs right now will have:
* Avro
* Protobuf
* Thrift
* Json
That list is laughably bad. Adding another that's less supported than the above
ones just seems like nih. Then we're going to have to write and maintain our
own rpc stack. Something that provides almost no value to the end user.
There are plenty of prefectly workable rpc's already that work:
* Thrift
** Just have an rpc that's write some set of spans. Call that whenever the
buffer is full
* GRPC
** Already has streaming so just implement that.
Anything but another rpc format that I have to know about.
> htrace hrpc: use msgpack for serialization
> ------------------------------------------
>
> Key: HTRACE-164
> URL: https://issues.apache.org/jira/browse/HTRACE-164
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-164.002.patch
>
>
> htrace HRPC should use msgpack for serialization. Messages serialized using
> msgpack use less space on the wire and use less CPU time to encode. The CMP
> library allows us to include msgpack support easily in the htrace C client.
> There is also good Java and Golang support available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
