[
https://issues.apache.org/jira/browse/HTRACE-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539282#comment-14539282
]
Colin Patrick McCabe commented on HTRACE-164:
---------------------------------------------
bq. So I still think that msg pack and rolling rpc is about as fun as a sharp
stick in the eye. However if we commit msgpack, make it pluggable, and
investigate other options later on then I'd be fine with the above patch.
Thanks, Elliot. I'm going to file a JIRA for making the C client pluggable in
much the same way that the Java one is in just a sec.
bq. We should specify that msg pack is the current speedy alternative. With
that comes the possibility that it might need to be changed or replaced in the
future. Our json will be there for fall back compatibiliy.
I added a comment to htraced.c saying:
{code}
+ * Note that we may change the serialization in the future if we discover
better
+ * alternatives. Sending spans over HTTP as JSON will always be supported
+ * as a fallback.
{code}
bq. +1
Thanks, will commit shortly. I'll link in the follow-on JIRAs.
> htrace hrpc: use msgpack for serialization
> ------------------------------------------
>
> Key: HTRACE-164
> URL: https://issues.apache.org/jira/browse/HTRACE-164
> Project: HTrace
> Issue Type: Bug
> Affects Versions: 3.2.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HTRACE-164.002.patch
>
>
> htrace HRPC should use msgpack for serialization. Messages serialized using
> msgpack use less space on the wire and use less CPU time to encode. The CMP
> library allows us to include msgpack support easily in the htrace C client.
> There is also good Java and Golang support available.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
